Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec interface for custom pals #23

Closed
wants to merge 2 commits into from
Closed

spec interface for custom pals #23

wants to merge 2 commits into from

Conversation

simonpcouch
Copy link
Owner

So close to this being where I want it to be, but struggling to get it over the finish line.

The idea is that pal_add() will do all the work to configure an addin and then trigger whatever hook RStudio uses to refresh the addins registered for a package. So, a user can interactively add a pal using just a role and a prompt that will be an addin that lasts for as long as the session. For whatever reason, I can get this to work with devtools::load_all(pkg_path) run interactively, but not via a helper or via pkgload. This feels related.

boop_small.mov

In general, doing away with leaning so heavily on the keyboard shortcut interface, instead preferring the command palette, as one will probably run out of reasonably accessible/memorable shortcuts pretty quickly.

@simonpcouch
Copy link
Owner Author

Related to #4 and #7.

@simonpcouch
Copy link
Owner Author

Another possible interface here is to just have one, "regular" add-in that's a Shiny Gadget with an interface like Continue—press some key command (or trigger via addins list), a dialog box pops with a text field, type in an enum with autocompletion (just the role—e.g. "cli" or "testthat"). This would diverge from how (I think) we're planning for the Positron interface to feel, though, where there are just "addins" registered with a "Pal: " prefix that can be dynamically registered (similar to what this PR aims for right now.)

@simonpcouch
Copy link
Owner Author

Closing in favor of the approach in #26.

@simonpcouch simonpcouch deleted the custom-addin branch October 10, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant